Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest Catalog: table_exist does not succeed on 204 response code #735

Closed
c-thiel opened this issue May 14, 2024 · 2 comments 路 Fixed by #739
Closed

Rest Catalog: table_exist does not succeed on 204 response code #735

c-thiel opened this issue May 14, 2024 · 2 comments 路 Fixed by #739

Comments

@c-thiel
Copy link
Contributor

c-thiel commented May 14, 2024

Apache Iceberg version

main (development)

Please describe the bug 馃悶

Currently table_exists only returns true on 200:

return response.status_code == 200

According to the spec, it should return true on 204 (and probably 200 as well):
https://github.com/apache/iceberg/blob/ea916c1700ef37377d3e8bba1197b3fe32d1a248/open-api/rest-catalog-open-api.yaml#L820-L829

@Fokko
Copy link
Contributor

Fokko commented May 14, 2024

@c-thiel Great catch! I agree, let's accept both 200 and 204. Are you interested in fixing this?

@c-thiel
Copy link
Contributor Author

c-thiel commented May 14, 2024

Sure - PR is coming. I'll have some more tricky great catches tomorrow ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants