Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the equality delta writer #343

Open
Tracked by #346
ZENOTME opened this issue Apr 23, 2024 · 5 comments
Open
Tracked by #346

Implement the equality delta writer #343

ZENOTME opened this issue Apr 23, 2024 · 5 comments

Comments

@ZENOTME
Copy link
Contributor

ZENOTME commented Apr 23, 2024

After #340 #341, we can implement the equality delta writer.

There is a rust implementation in icelake can be refer

@liurenjie1024
Copy link
Collaborator

Hi, @ZENOTME Since we have finished the framework, I'm thinking about providing a high level api such as append in python first rather providing these low level apis, what do you think?

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Apr 23, 2024

Hi, @ZENOTME Since we have finished the framework, I'm thinking about providing a high level api such as append in python first rather providing these low level apis, what do you think?

Sure. I can work on it later and add the e2e test for the writer. But can this work be done in parallel with low-level writers, seems there are someone interested in them.

@QuakeWang
Copy link
Contributor

Please assign it to me, I will do it later : )

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Apr 24, 2024

Please assign it to me, I will do it later : )

Sure. Thanks! But this issue was blocked by #341 #340 now.

@QuakeWang
Copy link
Contributor

Please assign it to me, I will do it later : )

Sure. Thanks! But this issue was blocked by #341 #340 now.

OK, I get it. I will proceed after #340 and #341 are completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants