#ignite-268: onUndeploy should be called one time for each cache.

apache · Feb 16, 2015 · 156e0c1 · 156e0c1
1 parent bbf5163
commit 156e0c1
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 19 deletions.
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
@@ -1211,7 +1211,7 @@ private boolean poke0(K key, @Nullable V newVal) throws IgniteCheckedException {
      * @param ldr Class loader to undeploy.
      */
     public void onUndeploy(ClassLoader ldr) {
-        ctx.deploy().onUndeploy(ldr);
+        ctx.deploy().onUndeploy(ldr, context());
     }
 
     /** {@inheritDoc} */

diff --git a/...src/main/java/org/apache/ignite/internal/processors/cache/GridCacheDeploymentManager.java b/...src/main/java/org/apache/ignite/internal/processors/cache/GridCacheDeploymentManager.java
@@ -205,35 +205,32 @@ public void unwind(GridCacheContext ctx) {
      * Undeploys given class loader.
      *
      * @param ldr Class loader to undeploy.
+     * @param ctx Grid cache context.
      */
-    public void onUndeploy(final ClassLoader ldr) {
+    public void onUndeploy(final ClassLoader ldr, final GridCacheContext<K, V> ctx) {
         assert ldr != null;
 
         if (log.isDebugEnabled())
             log.debug("Received onUndeploy() request [ldr=" + ldr + ", cctx=" + cctx + ']');
 
         synchronized (undeploys) {
-            for (final GridCacheContext<K, V> cacheCtx : cctx.cacheContexts()) {
+            List<CA> queue = undeploys.get(ctx.name());
-                List<CA> queue = undeploys.get(cacheCtx.name());
 
-                if (queue == null)
+            if (queue == null)
-                    undeploys.put(cacheCtx.name(), queue = new ArrayList<>());
+                undeploys.put(ctx.name(), queue = new ArrayList<>());
 
-                queue.add(new CA() {
+            queue.add(new CA() {
-                    @Override
+                @Override
-                    public void apply() {
+                public void apply() {
-                        onUndeploy0(ldr, cacheCtx);
+                    onUndeploy0(ldr, ctx);
-                    }
+                }
-                });
+            });
-            }
         }
 
-        for (GridCacheContext<K, V> cacheCtx : cctx.cacheContexts()) {
+        // Unwind immediately for local and replicate caches.
-            // Unwind immediately for local and replicate caches.
+        // We go through preloader for proper synchronization.
-            // We go through preloader for proper synchronization.
+        if (ctx.isLocal())
-            if (cacheCtx.isLocal())
+            ctx.preloader().unwindUndeploys();
-                cacheCtx.preloader().unwindUndeploys();
-        }
     }
 
     /**