Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Open API specification for Admin API #1146

Closed
sshniro opened this issue Feb 21, 2020 · 10 comments
Closed

Feature: Open API specification for Admin API #1146

sshniro opened this issue Feb 21, 2020 · 10 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sshniro
Copy link
Member

sshniro commented Feb 21, 2020

Issue description

Is there an Open API (Swagger) specification to admin API? If so it can be easily used to define and maintain APIs, generate API docs and import in API testing tools like the postman.

@membphis
Copy link
Member

We do not have it now. Any good suggestions?

@sshniro
Copy link
Member Author

sshniro commented Feb 21, 2020

Okay, shall I start creating an Open API specification for Admin API? After the YAML file is generated, we can use:

  1. Redoc This is interactive, we can connect the demo sandbox API SIX environment for this.
  2. Slate

Both can be used to show example invocations and autogenerate code for multiple languages.

@membphis
Copy link
Member

I'm not very good at this, we can listen to other people's opinions.

Their licenses are friendly, it's very nice.

@moonming
Copy link
Member

I tried both, I prefer the Reddoc. @sshniro What do you think?

@sshniro
Copy link
Member Author

sshniro commented Feb 26, 2020

@moonming yea I agree, as Admin API has comparatively less APIs Redoc will be good. Slate will be ideal if there are a lot of high-level documents to be written (API Orchestration examples).

@membphis membphis added the enhancement New feature or request label Feb 26, 2020
@moonming moonming added the help wanted Extra attention is needed label Mar 12, 2020
@moonming
Copy link
Member

@sshniro do you want to add Redoc for Apache APISIX?

@sshniro
Copy link
Member Author

sshniro commented Mar 12, 2020

Yes @moonming I would like to initially add the open API specs, but currently working with the HTTP logger. After that, I can start working on this issue.

@membphis
Copy link
Member

membphis commented Jul 1, 2020

@sshniro can we close this issue now?

@sshniro
Copy link
Member Author

sshniro commented Aug 13, 2020

I did not have time to check on this feature, will try this after merging the docs with the website.

@spacewander
Copy link
Member

Since we plan to use manager API to replace admin API, there is no need to investigate into the old one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants