Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: The recommended value for worker_shutdown_timeout is 240 seconds. #1853

Closed
Miss-you opened this issue Jul 16, 2020 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@Miss-you
Copy link
Member

Miss-you commented Jul 16, 2020

Issue description

current

  worker_shutdown_timeout: 3s     # timeout for a graceful shutdown of worker processes

https://github.com/apache/incubator-apisix/blob/master/conf/config.yaml#L104

recommendation

  worker_shutdown_timeout: 240s     # timeout for a graceful shutdown of worker processes

reasons:

  1. 3 seconds is too short, once a graceful restart will quickly disconnect the long connection
  2. The default value for nginx ingress is 240 seconds.

image

Environment

  • apisix version (cmd: apisix version):
  • OS:

Minimal test code / Steps to reproduce the issue

What's the actual result? (including assertion message & call stack if applicable)

What's the expected result?

@moonming
Copy link
Member

@Miss-you agreed , welcome PR

@shuaijinchao
Copy link
Member

the problem has been fixed, I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants