Allow add custom shared dict #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you need to add one shared dict, then you will using this shared dict in Lua code, right? |
Yes, I need add some custom plugin. I used the mlcache library, which needs to add some shared caches. |
|
Got it. |
moonming
requested changes
Mar 30, 2020
conf/config.yaml
Outdated
| @@ -111,6 +111,8 @@ nginx_config: # config for render the template to genarate n | |||
| real_ip_from: # http://nginx.org/en/docs/http/ngx_http_realip_module.html#set_real_ip_from | |||
| - 127.0.0.1 | |||
| - 'unix:' | |||
| lua_shared_dicts: | |||
| ipc_shared_dict: 100m # custom shared cache | |||
There was a problem hiding this comment.
should be commented by default.
moonming
reviewed
Mar 30, 2020
membphis
approved these changes
Mar 31, 2020
moonming
approved these changes
Mar 31, 2020
SaberMaster
pushed a commit
to SaberMaster/incubator-apisix
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Please read the Contributing.md guidelines before submitting your patch:
https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
Summary
Allows you to add custom shared dict through configuration
Full changelog