Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: old test case is unstable, running fail sometimes. #1925

Merged
merged 1 commit into from Jul 31, 2020
Merged

test: old test case is unstable, running fail sometimes. #1925

merged 1 commit into from Jul 31, 2020

Conversation

membphis
Copy link
Member

@membphis membphis commented Jul 29, 2020

What this PR does / why we need it:

as title.

In test 3 of the old use case, both the old and new configurations may trigger errors and generate logs, and they are random. There should be only one error at a time, which makes it easier to ensure stable testing.

unstable output: https://github.com/apache/incubator-apisix/runs/921554160?check_suite_focus=true#step:6:121

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@membphis membphis merged commit 3d8150b into apache:master Jul 31, 2020
@membphis membphis deleted the unstable-test-case branch July 31, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants