Skip to content

Commit

Permalink
fixup! Make PassThroughWindowFn and NeverTrigger available
Browse files Browse the repository at this point in the history
  • Loading branch information
tgroh committed Apr 14, 2016
1 parent e2b10af commit 52e2c65
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ private static class AfterWatermarkEarlyAndLate
@SuppressWarnings("unchecked")
private AfterWatermarkEarlyAndLate(OnceTrigger earlyTrigger, OnceTrigger lateTrigger) {
super(lateTrigger == null
? ImmutableList.<Trigger>of(earlyTrigger)
: ImmutableList.<Trigger>of(earlyTrigger, lateTrigger));
? ImmutableList.<Trigger>of(earlyTrigger)
: ImmutableList.<Trigger>of(earlyTrigger, lateTrigger));
this.earlyTrigger = checkNotNull(earlyTrigger, "earlyTrigger should not be null");
this.lateTrigger = lateTrigger;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.apache.beam.sdk.transforms.windowing.Window;
import org.apache.beam.sdk.transforms.windowing.WindowFn;
import org.apache.beam.sdk.values.PCollection;

import org.joda.time.Instant;

import java.util.Collection;
Expand Down Expand Up @@ -81,7 +82,7 @@ public boolean isCompatible(WindowFn<?, ?> other) {
String.format(
"%s.isCompatible() should never be called."
+ " It is a private implementation detail of sdk utilities."
+ " This message indicates a bug in the Dataflow SDK.",
+ " This message indicates a bug in the Beam SDK.",
getClass().getCanonicalName()));
}

Expand All @@ -102,8 +103,8 @@ public BoundedWindow getSideInputWindow(BoundedWindow window) {
throw new UnsupportedOperationException(
String.format(
"%s.getSideInputWindow() should never be called."
+ " It is a private implementation detail sdk utilities."
+ " This message indicates a bug in the Dataflow SDK.",
+ " It is a private implementation detail of sdk utilities."
+ " This message indicates a bug in the Beam SDK.",
getClass().getCanonicalName()));
}

Expand Down

0 comments on commit 52e2c65

Please sign in to comment.