DebuggingWordCount now takes filter as an option #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was hard-coded as "Flourish|stomach". Now it is a PipelineOption with that as the default. This allows "breaking" the pipeline by mis-specifying the pattern without changing the code.
| @@ -172,6 +172,12 @@ public String apply(KV<String, Long> input) { | |||
| String getOutput(); | |||
| void setOutput(String value); | |||
|
|
|||
| @Description("Regex filter pattern to use in DebuggingWordCount. " | |||
There was a problem hiding this comment.
move the option to DebuggingWordCount.
|
LGTM. |
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
#! Remove obsolete classes and forbid custom Pairs/Triples
becketqin
pushed a commit
to becketqin/beam
that referenced
this pull request
Jan 18, 2024
Explicitly force execution order for some required modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow DebuggingWordCount to take the filter to be matched as an option.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
mvn clean verify. (Even better, enableTravis-CI for on your fork and ensure the whole test matrix passes).
number, if there is one.
Individual Contributor License Agreement.
Previously it was hard-coded as "Flourish|stomach".
Now it is a PipelineOption with that as the default.
This allows "breaking" the pipeline by mis-specifying the pattern
without changing the code.