Remove unnecessary rawtype cast #1121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjchambers
referenced
this pull request
Oct 17, 2016
This required fixing GBKIntoKeyedWorkItems to properly set the coder on the primitive, and updating the assertions to match the actual (and correct) behavior.
jkff
reviewed
Oct 17, 2016
| @@ -49,7 +49,7 @@ | |||
| input.getWindowingStrategy().getWindowFn().windowCoder()); | |||
| PCollection<KeyedWorkItem<KeyT, InputT>> collection = PCollection.createPrimitiveOutputInternal( | |||
There was a problem hiding this comment.
Another option is to use PCollection.<KeyedWorkItem<...>>.createPrimitiveOutputInternal and inline both variables, but this is ok too.
There was a problem hiding this comment.
I think I'll leave it. Trying to inline the collection requires using setCoder which then requires specifying the type for the createPrimitiveOutputInternal which makes the formatting much worse.
jkff
approved these changes
Oct 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
R: @jkff