[BEAM-860] Move Apache RAT license check out of release profile #1221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull request
mvn clean verify
. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>
in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
Move Apache RAT license check out of release profile. It runs quickly, so can run as a part of normal mvn verify phase. Will make it so missing licenses are caught locally more easily.
Tested this locally by removing the license from a file and running 'mvn clean verify' as well as 'mvn clean verify -P release'. Now both fail, whereas previously, only 'mvn clean verify -P release' failed.
See discussion at #1199 (comment)
Would you mind looking @dhalperi ? Sorry to send 100% of my two PRs so far to you, but you do have context on this one...