Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-860] Move Apache RAT license check out of release profile #1221

Closed
wants to merge 1 commit into from

Conversation

mizitch
Copy link
Contributor

@mizitch mizitch commented Oct 28, 2016

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Move Apache RAT license check out of release profile. It runs quickly, so can run as a part of normal mvn verify phase. Will make it so missing licenses are caught locally more easily.

Tested this locally by removing the license from a file and running 'mvn clean verify' as well as 'mvn clean verify -P release'. Now both fail, whereas previously, only 'mvn clean verify -P release' failed.

See discussion at #1199 (comment)

Would you mind looking @dhalperi ? Sorry to send 100% of my two PRs so far to you, but you do have context on this one...

…, so can run as a part of normal mvn verify phase. Will make it so missing licenses are caught locally more easily.
@mizitch
Copy link
Contributor Author

mizitch commented Oct 28, 2016

Travis failures are pre-existing recurring ones related to Spark runner compilation and Spark runner test failure

@jbonofre
Copy link
Member

R: @jbonofre

@dhalperi
Copy link
Contributor

Spoke with some other folks in person. I think we want to keep the default mvn verify profile to only the subsets of commands that a Beam user wants to run. To that end:

  • we should leave RAT off
  • we should remove checkstyle and other similar things
  • we should document very concisely in the contribution guide what command Jenkins precommit runs (maybe it should be -Pprecommit ?) for contributors who want to test locally

@jbonofre
Copy link
Member

+1, it makes sense to me.

@mizitch mizitch closed this Oct 31, 2016
@mizitch
Copy link
Contributor Author

mizitch commented Oct 31, 2016

Makes sense, closing this PR, some further commentary on the JIRA: https://issues.apache.org/jira/browse/BEAM-860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants