[BEAM-905] Add shading config to examples archetype and enable it for Flink #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Flink This makes the Flink quickstart work out of the box.
dhalperi
changed the title
|
Refer to this link for build results (access rights to CI server needed): |
|
LGTM! The quickstart instructions for the Flink runner would not actually be working without this. When I wrote them I must have copied the shading part from the java examples pom to my generated word count example POM. |
|
LGTM. (Please self merge.) |
|
Thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @davorbonaci AND @aljoscha
This makes the Flink quickstart work out of the box.