[BEAM-78] Rename com.google.cloud.dataflow to org.apache.beam #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Move files, instead of remove & add. |
added 17 commits
April 13, 2016 17:34
Applied this script:
mkdir -p $1/org/apache/beam;
git mv $1/com/google/cloud/dataflow/* $1/org/apache;
rmdir -p $1/com/google/cloud/dataflow;
To these directories:
- sdks/java/core/src/{main,test}
- sdks/java/java8tests/src/test
- runners/google-cloud-dataflow-java/src/{main,test}
- contrib/{join-library,hadoop}/src/{main,test}
- examples/java{,8}/src/{main,test}
Performed using the following script
find . -iname "*.java" -exec sed -i -e \
"s/package com.google.cloud.dataflow/package org.apache.beam/" {} +
Performed using the following command:
find . -iname "*.java" -exec sed -i -e \
"s/com.google.cloud.dataflow/org.apache.beam/" {} +
Revert changes to imports of proto2 coders (deployed to maven)
bjchambers
force-pushed
the
rename-packages
branch
from
aa4adc3
to
d07d775
Compare
|
Done. This required rebuilding the entire PR -- Git doesn't have a notion of "move". It detects this within each commit. Since the commit has so many files modified, it bypasses the "detect moves in files with N% changed". I had to restructure it as a commit that moves everything without changing contents (so it can detect diffs by just looking at the MD5 hashes) and then a series of commits to fix the build. Important note: When merging, we cannot squash any changes into the commit that does the moves. Any modified files will not be recorded as moves. |
|
R: @lukecwik |
|
When merging, note that each of the fixup! commits can be squashed, but contains a description of the changes that needed to be performed (and/or scripts used) to make edits. It may be worth preserving those for historical purposes. |
bjchambers
changed the title
bjchambers
changed the title
|
A few minor comments:
All this is minor and can be addressed later. Merge in progress. |
tgroh
added a commit
to tgroh/beam
that referenced
this pull request
Apr 14, 2016
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
Explicitly track the Source a ReadEvaluator is using
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
…tations [euphoria-core] add API audience annotations to core
Abacn
pushed a commit
to Abacn/beam
that referenced
this pull request
Jan 31, 2023
Please approve this CL. It will be submitted automatically, and its GitHub pull request will be marked as merged. Imported from GitHub PR apache#176 This PR adds Kafka to PubSub Flex template. Copybara import of the project: - 7aceebf9219d17becb789b6ccff647ee6ded6420 Implemented Kafka to Pub/Sub template by Artur Khanin <artur.khanin@akvelon.com> COPYBARA_INTEGRATE_REVIEW=GoogleCloudPlatform/DataflowTemplates#176 from akvelon:KafkaToPubsubTemplate 7aceebf9219d17becb789b6ccff647ee6ded6420 PiperOrigin-RevId: 343484865
Abacn
pushed a commit
to Abacn/beam
that referenced
this pull request
Jan 31, 2023
PiperOrigin-RevId: 343754906
Abacn
pushed a commit
to Abacn/beam
that referenced
this pull request
Jan 31, 2023
Please approve this CL. It will be submitted automatically, and its GitHub pull request will be marked as merged. Imported from GitHub PR apache#176 This PR adds Kafka to PubSub Flex template. PiperOrigin-RevId: 345486564
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Co-authored-by: Tres Seaver <tseaver@palladion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
Note that this doesn't rename everything possible. Follow-up work that remains includes at least:
README.mdsProtoCodertests to use them.