[BEAM-433] Remove Dataflow references in ExampleOptions #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peihe
force-pushed
the
example-options
branch
3 times, most recently
from
4d3fd36
to
21b84a6
Compare
| */ | ||
| public interface DataflowExampleOptions extends DataflowPipelineOptions { | ||
| public interface ExampleOptions extends PipelineOptions { | ||
| @Description("Whether to keep jobs running on the Dataflow service after local process exit") |
There was a problem hiding this comment.
This line references Dataflow-- should we remove it entirely?
There was a problem hiding this comment.
updated the description for now.
I am not removing references to this options, since it might be useful for other runners.
|
not ready for review yet |
peihe
force-pushed
the
example-options
branch
3 times, most recently
from
1c032cc
to
49b519c
Compare
peihe
changed the title
|
obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.