Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-286] Reorganize flink runner module to follow other runners str… #348

Closed
wants to merge 1 commit into from

Conversation

jbonofre
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Reorganize flink runner module to follow other runners structure.

@jbonofre
Copy link
Member Author

R: @mxm
R: @aljoscha

@aljoscha
Copy link
Contributor

Since this is mostly touching POMs and removing examples it shouldn't clash to much with #343. You'll probably have to coordinate with with @jasonkuster on #345.

LGTM to me, since it's mostly removing examples that were originally copied from the Google Dataflow (not a mistake) code base. Let's wait and see what @mxm has to say.

@jasonkuster
Copy link
Contributor

Looks like this is a superset of the flink stuff I'm doing in #345. Since this makes more changes, I'm happy to revert the flink changes I've made, wait for this to go in, and then rebase to pick this up.

@jbonofre
Copy link
Member Author

@aljoscha Thanks for the update.
@jasonkuster up to you, but maybe we can start with this "move" and then apply your change.

@mxm
Copy link
Contributor

mxm commented May 20, 2016

I commented on the JIRA issue. I don't think we can merge this PR. However, we could get rid of some of the examples in a separate issue/pull request.

@davorbonaci
Copy link
Member

Triage: 0.1.0-incubating, release blocking.

Let's continue the discussion in JIRA.

@jbonofre
Copy link
Member Author

For now, I'm closing this PR.

@jbonofre jbonofre closed this Jul 14, 2016
@jbonofre jbonofre deleted the BEAM-286-REORG-FLINK branch October 5, 2016 08:57
iemejia pushed a commit to iemejia/beam that referenced this pull request Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants