[BEAM-355] Update to Bigtable version 0.3.0 #481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ptal @dhalperi |
| /** | ||
| * A helper function to produce a Cloud Bigtable user agent string. | ||
| */ | ||
| public static BigtableOptions.Builder addRetryOptions(BigtableOptions.Builder builder) { |
There was a problem hiding this comment.
Do these need to be public? If not, they should be package-protected.
Also, add tests for these.
There was a problem hiding this comment.
Did you file the bug against cloud-bigtable-client to add cloning or toBuilder to these methods? If not, please do so.
Add a link to that bug in the comment.
|
R: @dhalperi Ian, looks like there was some persistent problem in the service because it could not find part of the Google API clients.: Let's debug tomorrow. |
|
FYI bigtable-client 0.9.0 was just released and we verified that they work with our production jobs. |
|
@nevillelyh yep, thanks. Unfortunately, Bigtable team made backwards-incompatible changes in this release so we'll upgrade to 0.9 separately. |
johnjcasey
pushed a commit
to johnjcasey/beam
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.