BEAM-379: Add support for source Ptransform in DisplayDataEvaluator #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bjchambers @dhalperi @swegner Please take a look when you get a chance. |
| /** | ||
| * Traverse the specified source {@link PTransform}, collecting {@link DisplayData} registered | ||
| * on the inner primitive {@link PTransform PTransforms}. | ||
| * @param root The source root {@link PTransform} to traverse |
There was a problem hiding this comment.
blank line between main content and @param
|
LGTM |
|
👍 thanks for contributing this! |
johnjcasey
pushed a commit
to johnjcasey/beam
that referenced
this pull request
Feb 8, 2023
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Source-Link: googleapis/synthtool@ca87909 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
DisplayDataEvaluator takes PTranform<? extends PCollection, ? extends POutput>, but this doesn't work for source transforms of the form PTransform<PBegin, PCollection>. Add a new method that works for source PTransforms.