[BEAM-460] Add size-estimation support to Python SDK Coders #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @silviulica |
| @@ -172,6 +202,9 @@ def encode_to_stream(self, value, out, nested): | |||
| def decode_from_stream(self, in_stream, nested): | |||
| return in_stream.read_bigendian_double() | |||
|
|
|||
| def estimate_size(self, unused_value): | |||
There was a problem hiding this comment.
Can you please explain the 8 here?
|
LGTM - except a few minor comments |
|
Thanks, PTAL. |
|
LGTM |
|
@charlesccychen Is this ready per our in-person discussion yesterday? |
|
R: @robertwb Yes, the changes we settled on can use the same interface. |
| @@ -63,6 +65,27 @@ def decode(self, encoded): | |||
| """Encodes an object to an unnested string.""" | |||
| raise NotImplementedError | |||
|
|
|||
| def estimate_size(self, value): | |||
| """Estimates the encoded size of the given value, in bytes.""" | |||
| return len(self.encode(value)) | |||
There was a problem hiding this comment.
The default should use ByteCountingOutputStream, or at least override this in StreamCoderImpl to do so.
|
Thanks, PTAL. I've addressed your comments. |
|
LGTM |
charlesccychen
force-pushed
the
size-estimation-coders
branch
from
8378924
to
015b7e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change facilitates runner support for size-estimation counters.