Make TextFileReader observable #726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows future implementation of size tracking for elements in side input sources.
|
R: @silviulica |
|
LGTM |
|
@charlesccychen -- travis failures look real. Investigate before I merge? |
|
Yes. Also, please don't merge yet. This will go in after the beta. Thanks. On Tue, Jul 26, 2016, 11:16 AM Daniel Halperin notifications@github.com
|
|
Close at your leisure. |
|
Thanks. |
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
* chore: Add bloom filter related comments PiperOrigin-RevId: 538646627 Source-Link: googleapis/googleapis@1ceef69 Source-Link: https://github.com/googleapis/googleapis-gen/commit/fb7c4c4aef630f4957fa501c48587f983e17644a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmI3YzRjNGFlZjYzMGY0OTU3ZmE1MDFjNDg1ODdmOTgzZTE3NjQ0YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows future implementation of size tracking for elements in side input sources.