[BEAM-495] Create General Verifier for File Checksum #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markflyhigh
changed the title
|
LGTM |
markflyhigh
force-pushed
the
create-FileChecksumVerifier
branch
from
3a455f9
to
dca4f2a
Compare
|
|
||
| thrown.expect(IllegalArgumentException.class); | ||
| thrown.expectMessage(containsString("Expected valid checksum, but received")); | ||
| new FileChecksumMatcher(null, tmpPath); |
There was a problem hiding this comment.
this line will throw so that means that the line below will never get called
You need to either catch and verify yourself or split this into two tests, one with null and one with ""
markflyhigh
force-pushed
the
create-FileChecksumVerifier
branch
from
dca4f2a
to
c560497
Compare
| FileChecksumMatcher matcher = | ||
| new FileChecksumMatcher( | ||
| "90552392c28396935fe4f123bd0b5c2d0f6260c8", | ||
| tmpFolder.getRoot().getPath() + "/*"); |
There was a problem hiding this comment.
Use IOChannelUtils.resolve or equivalent, your assuming all filesystems use '/' as the separator
markflyhigh
force-pushed
the
create-FileChecksumVerifier
branch
from
0a0b5e7
to
6e8eb82
Compare
|
PTAL @lukecwik |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
JIRA(https://issues.apache.org/jira/browse/BEAM-495)
Generalize FileChecksumMatcher which is from WordCountIT. FileChecksumMatcher can be used in E2E test to verify checksum of output result.