New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct some accidental renames #778
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM. |
@@ -81,15 +81,15 @@ | |||
* <p>This method is called to create an aggregator for a {@link DoFn}. It receives the class | |||
* of the {@link DoFn} being executed and the context of the step it is being executed in. | |||
*/ | |||
<InputT, AccumT, OutputT> Aggregator<InputT, OutputT> createAggregatorForDoFn( | |||
<InputT, AccumT, OutputT> Aggregator<InputT, OutputT> createAggregator( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one needs revert I believe.
Also now needs a merge on top of Kenn's magic. |
bjchambers
force-pushed
the
fix-javadoc
branch
from
August 10, 2016 18:33
a39d682
to
3f3a57d
Compare
Rebased. |
Build failing:
|
bjchambers
force-pushed
the
fix-javadoc
branch
from
August 17, 2016 23:24
3f3a57d
to
153e053
Compare
Build still failing:
|
Still pending, looks like? |
IDE over-eagerly replaced some occurrences of createAggregator with createAggregatorForDoFn. This corrects that.
bjchambers
force-pushed
the
fix-javadoc
branch
from
August 30, 2016 21:14
153e053
to
3887cec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull request
mvn clean verify
. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>
in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
IDE over-eagerly replaced some occurrences of createAggregator with
createAggregatorForDoFn. This corrects that.