Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

从release的源代码编译时无法获取BRPC_VERSION #969

Closed
straywarrior opened this issue Nov 19, 2019 · 1 comment
Closed

从release的源代码编译时无法获取BRPC_VERSION #969

straywarrior opened this issue Nov 19, 2019 · 1 comment

Comments

@straywarrior
Copy link

Describe the bug (描述bug)
编译时git操作报错
fatal: Not a git repository (or any parent up to mount point /)
可以继续编译,但会有大量上述错误信息

To Reproduce (复现方法)
下载release的代码包,例如 https://github.com/apache/incubator-brpc/archive/0.9.6.tar.gz,执行config_brpc.sh; make

Expected behavior (期望行为)

Versions (各种版本)
OS: CentOS 6
Compiler: gcc 4.9.2
brpc: 0.9.6
protobuf: 3.5.2

Additional context/screenshots (更多上下文/截图)
错误来自于Makefile中的git命令(已省略其它不相关内容):

CPPFLAGS+=-DBRPC_REVISION=\"$(shell git rev-parse --short HEAD)\"

使用release的代码包时,没有git目录导致报错

@zyearn
Copy link
Member

zyearn commented Dec 25, 2019

Fixed in #984

@zyearn zyearn closed this as completed Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants