Test case for bug in RexBuilder.ensureType() function #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have logged https://issues.apache.org/jira/browse/CALCITE-807 to track this. |
|
Can you please close this pull request? I added test case code to https://issues.apache.org/jira/browse/CALCITE-807. |
pfzhan
pushed a commit
to pfzhan/calcite
that referenced
this pull request
May 17, 2020
* ProjectToWindowRule - correct cohort dependence checking * r21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bug in RexBuilder.esnureType() function when we pass 'matchNullability' = false as a parameter. The underlying equals() function compares the digest of the two types and is not aware of the 'matchNullability'. So if the nullability differs the equals would return false and we end up adding an extra cast. Below is a unit test for this issue.
One solution to this issue can be adding equalsIgnoreNullability() to the RelDataType interface (while performing the comparison of digests ignoring the ' not null'). However since I am not well versed with this logic if there are other suggestions I can work on it to contributing a patch.
P.S: JIRA seems to be down so haven't tagged this PR with a JIRA#, will do that once its up.