Fix incorrect diagnostic. #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is DAFFODIL-2204. Will add to the commit message. |
mbeckerle
force-pushed
the
daffodil-2204-delim-msg
branch
from
7e7e617
to
620cc8f
Compare
I.e., message like Parse Error: Initiator ';' not found. Except ";" is the terminator of the element, not the initiator. Due to object-construction-timing stuff I think. That or scala bugs. But sub-class overrides were not happening to provide the member from which this name was derived. Why it got the wrong one, I don't know, I would have expected "unbound/undefined" or something. Just passing the parameter to constructor rather than overriding a member to provide it, solves the problem. DAFFODIL-2204
mbeckerle
force-pushed
the
daffodil-2204-delim-msg
branch
from
620cc8f
to
137e9e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing terminator was reporting itself as a missing initiator.
I.e., message like Parse Error: Initiator ';' not found.
Except ";" is the terminator of the element, not the initiator.
Due to object-construction-timing stuff I think. That or scala bugs.
But sub-class overrides were not happening to provide the member from
which this name was derived. Why it got the wrong one, I don't know, I
would have expected "unbound/undefined" or something.
Just passing the parameter to constructor rather than overriding a
member to provide it, solves the problem.