Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CLI integration tests so that they run properly on Windows. #170

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Fixed CLI integration tests so that they run properly on Windows. #170

merged 1 commit into from
Jan 29, 2019

Conversation

ltapilot
Copy link
Contributor

mbeckerle
mbeckerle approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@mbeckerle mbeckerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - with fix (if I am in fact right) to two spots where Util.echoN may also apply.

daffodil-cli/src/it/scala/org/apache/daffodil/tunables/TestCLITunables2.scala Show resolved Hide resolved
daffodil-cli/src/it/scala/org/apache/daffodil/tunables/TestCLITunables2.scala Show resolved Hide resolved
jadams-tresys
jadams-tresys requested changes Jan 28, 2019
View reviewed changes
build.sbt Show resolved Hide resolved
jadams-tresys
jadams-tresys approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@jadams-tresys jadams-tresys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@stevedlawrence stevedlawrence merged commit 629aa2a into apache:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevedlawrence stevedlawrence stevedlawrence left review comments

@mbeckerle mbeckerle mbeckerle approved these changes

@jadams-tresys jadams-tresys jadams-tresys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ltapilot @mbeckerle @stevedlawrence @jadams-tresys