Allow same character for escapeBlockEnd and escapeEscapeCharacter #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the issue where the escapeBlockEnd and escapeEscapeCharacter are the same character. This is apparently a common thing in how Excel escapes things in CSV. This is not a complete fix as there are still issues in cases like escapeBlockEnd="++" and escapeEscapeCharacter='+', but there does not seem to be an easy way to deal with these extreme edge cases cleanly in the existing code. This issue has been documented in DAFFODIL-1972 DAFFODIL-1923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue where the escapeBlockEnd and
escapeEscapeCharacter are the same character. This is apparently a
common thing in how Excel escapes things in CSV.
This is not a complete fix as there are still issues in cases like
escapeBlockEnd="++" and escapeEscapeCharacter='+', but there does not
seem to be an easy way to deal with these extreme edge cases cleanly in
the existing code. This issue has been documented in DAFFODIL-1972
DAFFODIL-1923