Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Framework] Support for Project, Blueprint and Scope deletion #4864

Closed
3 tasks done
keon94 opened this issue Apr 6, 2023 · 4 comments
Closed
3 tasks done
Assignees
Labels
component/framework This issue or PR relates to the framework type/epic This is an epic issue type/feature-request This issue is a proposal for something new
Milestone

Comments

@keon94
Copy link
Contributor

keon94 commented Apr 6, 2023

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Use case

Deleting projects, blueprints and scopes is currently unsupported. This ticket will capture the R&D necessary to support this feature.

Description

There are technical challenges involved with this. The main question is, how can we purge all the domain-level data associated with a blueprint once we delete that blueprint? We need a way to perform that mapping so we know what to delete from the database.

Child issues

Scope deletion (PagerDuty + AzureDevops): #4762
UI work: #4388
Blueprint deletion PR: #5227
Project deletion PR: #5289
Scope deletion (Other plugins): #5277

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@keon94 keon94 added the type/feature-request This issue is a proposal for something new label Apr 6, 2023
@keon94 keon94 self-assigned this Apr 6, 2023
@keon94
Copy link
Contributor Author

keon94 commented Apr 6, 2023

I'm assigning this to myself. cc @Startrekzky

@keon94 keon94 added the component/framework This issue or PR relates to the framework label Apr 6, 2023
@yumengwang03 yumengwang03 added this to the v0.18.0 milestone Apr 6, 2023
@yumengwang03
Copy link
Contributor

yumengwang03 commented Apr 6, 2023

Hi @keon94 here is some additional info: in v0.18, we will (most likely, but I need to confirm in the next a few days) move data scope and transformation to be managed at the data connection level, and Blueprints will only retain its association with the data scope, meaning that adding and deleting data scope need to be done in each data connection, not from the Blueprint anymore. Deleting data scope from a Blueprint doesn't delete the data scope, but delete its association with the Blueprint. This update will be addressed in this issue: #4762

I think this might also affect Project and Blueprint deletion.

@keon94
Copy link
Contributor Author

keon94 commented Apr 10, 2023

@yumengwang03 @Startrekzky Will it make more sense to repurpose this ticket to delete data based on scopes instead? Doing so will prevent data from getting tied the blueprint that created them
edit: nvm, I think doing that in #4762 will make more sense

@yumengwang03
Copy link
Contributor

Adding the prototypes here:
Screen Shot 2023-05-11 at 5 10 02 PM
Screen Shot 2023-05-11 at 5 10 34 PM

@keon94 keon94 added the type/epic This is an epic issue label May 26, 2023
@keon94 keon94 changed the title [Feature][Framework] Support for Project and Blueprint deletion [Feature][Framework] Support for Project, Blueprint and Scope deletion May 26, 2023
@keon94 keon94 closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/framework This issue or PR relates to the framework type/epic This is an epic issue type/feature-request This issue is a proposal for something new
Projects
None yet
Development

No branches or pull requests

3 participants