DL-205: Remove StatusCode dependency on DLException #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move proxy related class from protocol to proxy-protocol, changed client and service to proxy-client and proxy-service
|
Build finished. |
1 similar comment
|
Build finished. |
jiazhai
approved these changes
Jun 3, 2017
|
@leighst do you mind reviewing this as well? in this change, I try to separate the protocols used for core from the protocols used by proxy, also rename the modules to make them clear. |
|
looks good. i guess the choice here is to make it like bk, to some extent. personally i think having a pojo StatusCode object would be better than passing around ints which can be easily misinterpreted. but i dont have a strong opinion. |
leighst
approved these changes
Jun 11, 2017
asfgit
pushed a commit
that referenced
this pull request
Jun 12, 2017
Currently finagle heavily depends on an out-of-dated version - libthrift 5.0. Proxy modules (client, server) depend on this version, however the core library doesn't really depend on libthrift. This change is to change libthrift to 0.9.* in distributedlog-core and shade it to avoid it conflict with the version used by finagle. This change is based on #131 . The main change is at gitsha [6e58786](6e58786) Author: Sijie Guo <sijie@apache.org> Reviewers: Jia Zhai <None>, Leigh Stewart <lstewart@apache.org> Closes #132 from sijie/change_thrift_for_core_module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove StatusCode from exceptions. Use integer as exception codes.
Also re-organize the modules:
distributedlog-protocol (for core structures) and distributedlog-core (for core library).
proxy: distributedlog-proxy-protocol (new module for thrift generated protocol), distributedlog-proxy-client (proxy client) and distributedlog-proxy-server (proxy server)
benchmark & tutorials.