Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify front-end deployment manual deployment instructions #45

Merged
merged 4 commits into from
Dec 3, 2019
Merged

Modify front-end deployment manual deployment instructions #45

merged 4 commits into from
Dec 3, 2019

Conversation

lgcareer
Copy link
Contributor

@lgcareer lgcareer commented Dec 3, 2019

Modify front-end deployment manual deployment instructions

@lgcareer lgcareer requested a review from lenboo December 3, 2019 03:13
lenboo
lenboo requested changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should not display the apache download url in the document before release process completed.
@lgcareer @dailidong

@davidzollo
Copy link
Contributor

davidzollo commented Dec 3, 2019 •
edited

i think we should not display the apache download url in the document before release process completed.
@lgcareer @dailidong

document as a part of publish process, if not display, developer can't see what to check

@davidzollo
Copy link
Contributor

we also reminder 1.2.0 is upcoming version in our official website
image

@lenboo
Copy link
Contributor

lenboo commented Dec 3, 2019

we also reminder 1.2.0 is upcoming version in our official website
image

that's ok.

lenboo
lenboo approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit 9d46378 into apache:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzollo davidzollo davidzollo approved these changes

@lenboo lenboo lenboo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lgcareer @davidzollo @lenboo