Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The workflow import user's other project or other user's project, the database table t_ds_process_definition stores data incorrectly #1544

Closed
xingchun-chen opened this issue Dec 24, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@xingchun-chen
Copy link
Contributor

xingchun-chen commented Dec 24, 2019

*For better global communication, please give priority to using English description, thx! *

Describe the bug

  1. After the user successfully imported the workflow of user’s project B in project A, t_ds_process_definition.project_id is still project B, and project_id should be the project ID of project A
  2. The workflow of importing other users prompts success, but the data is not stored in the database table t_ds_process_definition

1.用户在A项目导入该用户B项目的工作流成功后,t_ds_process_definition.project_id仍为B项目的id,project_id应该为A项目的id
2.导入其他用户的工作流提示成功,但是数据未存入数据库

version
[1.2.0]

@xingchun-chen xingchun-chen added the bug Something isn't working label Dec 24, 2019
@davidzollo davidzollo added this to Requirement(需求) in DolphinScheduler Work Plan via automation Dec 25, 2019
@Eights-Li
Copy link
Contributor

Current workflow import:
1 Implementing workflow import under the same project, currently more like a workflow metadata backup mechanism
2 If multi-environment publishing is required, the metadata of users, tenants, etc. in the two environments is completely consistent
Idea:
1 First implement a cross-project workflow import in a DS environment(want to do)
2 Priority recommendations for multi-environment releases come after the dolphinscheduler resource directory and platform permissions design
当前工作流导入的特点:
1 实现同一项目下的工作流导入,目前更像是一种工作流元数据备份机制
2 如果要实现多环境发布,目前需要两个环境的用户,租户等等元数据名称一致
个人想法:
1 先实现一套DS环境中的,跨项目的工作流导入(可以做)
2 多环境发布的优先级建议排在dolphinscheduler资源目录和平台权限设计之后

@davidzollo
Copy link
Contributor

good,
I agree with your idea. first implement a cross-project workflow import in a DS environment.

@qiaozhanwei
Copy link
Contributor

+1

qiaozhanwei pushed a commit that referenced this issue Jan 2, 2020
* modify FileUtils.readFile2Str

* #1300 Add right alignment function in sql email content

* cancel formatted for alert_mail_template.ftl

* #747 sql task password Log desensitization

* cancel mail_temple

* edit ExcelUtils

* modify test method name

* #747 sql task password Log desensitization

* #1544 workflow import

* Constants add DATASOURCE_PASSWORD_REGEX

* #747 sql task password Log desensitization

* deal with import project have sub process

* modify export process addTaskNodeParam method name

* add testAddTaskNodeSpecialParam UT

* add ProcessDefinitionServiceTest-ut to pom

* add testImportSubProcess in ProcessDefinitionServiceTest

* add testImportSubProcess in ProcessDefinitionServiceTest

* add testImportProcessDefinition
qiaozhanwei pushed a commit that referenced this issue Jan 3, 2020
* modify FileUtils.readFile2Str

* #1300 Add right alignment function in sql email content

* cancel formatted for alert_mail_template.ftl

* #747 sql task password Log desensitization

* cancel mail_temple

* edit ExcelUtils

* modify test method name

* #747 sql task password Log desensitization

* #1544 workflow import

* Constants add DATASOURCE_PASSWORD_REGEX

* #747 sql task password Log desensitization

* deal with import project have sub process

* modify export process addTaskNodeParam method name

* add testAddTaskNodeSpecialParam UT

* add ProcessDefinitionServiceTest-ut to pom

* add testImportSubProcess in ProcessDefinitionServiceTest

* add testImportSubProcess in ProcessDefinitionServiceTest

* add testImportProcessDefinition

* fix sonar bug: not enough arguments
Technoboy- pushed a commit that referenced this issue Jan 4, 2020
* modify FileUtils.readFile2Str

* #1300 Add right alignment function in sql email content

* cancel formatted for alert_mail_template.ftl

* #747 sql task password Log desensitization

* cancel mail_temple

* edit ExcelUtils

* modify test method name

* #747 sql task password Log desensitization

* #1544 workflow import

* Constants add DATASOURCE_PASSWORD_REGEX

* #747 sql task password Log desensitization

* deal with import project have sub process

* modify export process addTaskNodeParam method name

* add testAddTaskNodeSpecialParam UT

* add ProcessDefinitionServiceTest-ut to pom

* add testImportSubProcess in ProcessDefinitionServiceTest

* add testImportSubProcess in ProcessDefinitionServiceTest

* add testImportProcessDefinition

* fix sonar bug: not enough arguments

* fix sonar bug: change condition & not enough arguments
qiaozhanwei pushed a commit that referenced this issue Jan 6, 2020
* modify FileUtils.readFile2Str

* #1300 Add right alignment function in sql email content

* cancel formatted for alert_mail_template.ftl

* #747 sql task password Log desensitization

* cancel mail_temple

* edit ExcelUtils

* modify test method name

* #747 sql task password Log desensitization

* #1544 workflow import

* Constants add DATASOURCE_PASSWORD_REGEX

* #747 sql task password Log desensitization

* deal with import project have sub process

* modify export process addTaskNodeParam method name

* add testAddTaskNodeSpecialParam UT

* add ProcessDefinitionServiceTest-ut to pom

* add testImportSubProcess in ProcessDefinitionServiceTest

* add testImportSubProcess in ProcessDefinitionServiceTest

* add testImportProcessDefinition

* fix sonar bug: not enough arguments

* fix sonar bug: change condition & not enough arguments

* fix bug sonar: add null check in daghelper && add hashcode method in ProcessData

* fix bug sonar: add null check in daghelper

* CollectionUtils.isEmpty()
qiaozhanwei pushed a commit that referenced this issue Jan 7, 2020
* modify FileUtils.readFile2Str

* #1300 Add right alignment function in sql email content

* cancel formatted for alert_mail_template.ftl

* #747 sql task password Log desensitization

* cancel mail_temple

* edit ExcelUtils

* modify test method name

* #747 sql task password Log desensitization

* #1544 workflow import

* Constants add DATASOURCE_PASSWORD_REGEX

* #747 sql task password Log desensitization

* deal with import project have sub process

* modify export process addTaskNodeParam method name

* add testAddTaskNodeSpecialParam UT

* add ProcessDefinitionServiceTest-ut to pom

* add testImportSubProcess in ProcessDefinitionServiceTest

* add testImportSubProcess in ProcessDefinitionServiceTest

* add testImportProcessDefinition

* fix sonar bug: not enough arguments

* fix sonar bug: change condition & not enough arguments

* fix bug sonar: add null check in daghelper && add hashcode method in ProcessData

* fix bug sonar: add null check in daghelper

* CollectionUtils.isEmpty()

* add hashcode() && null check

* merge if

* remove hashcode

* remove e.getMessage
DolphinScheduler Work Plan automation moved this from Requirement/TODO(需求/待做) to Done(当前完成的任务) Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants