Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][JUNIT TEST] Improvement UT OutOfMemory GC overhead limit #3288

Closed
felix-thinkingdata opened this issue Jul 23, 2020 · 1 comment · Fixed by #3305
Closed

[Improvement][JUNIT TEST] Improvement UT OutOfMemory GC overhead limit #3288

felix-thinkingdata opened this issue Jul 23, 2020 · 1 comment · Fixed by #3305

Comments

@felix-thinkingdata
Copy link
Contributor

*For better global communication, please give priority to using English description, thx! *

Please review https://dolphinscheduler.apache.org/en-us/docs/development/issue.html when describe an issue.

Describe the question
During the process of pr submission, the UT section often has the following problems.

OutOfMemory GC overhead limit

image
image

org.apache.dolphinscheduler.server.master.DependentTaskTest.txt
org.apache.dolphinscheduler.server.master.MasterExecThreadTest.txt
org.apache.dolphinscheduler.server.worker.registry.WorkerRegistryTest.txt
org.apache.dolphinscheduler.server.worker.task.sqoop.SqoopTaskTest.txt

What are the current deficiencies and the benefits of improvement

  • Take a look at these test classes. What causes the problems

Which version of DolphinScheduler:
-[dev]
@yangyichao-mango
Copy link
Contributor

+1,
Welcome to optimize the ut.

@yangyichao-mango yangyichao-mango mentioned this issue Jul 25, 2020
Merged
@davidzollo davidzollo linked a pull request Jul 25, 2020 that will close this issue
[Test-3288][server] Fix github ci unit test oom #3305
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Test-3288][server] Fix github ci unit test oom yangyichao-mango/incubator-dolphinscheduler
2 participants
@yangyichao-mango @felix-thinkingdata