Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Master] there exists some problems in checking task dependency #3324

Closed
legen618 opened this issue Jul 27, 2020 · 7 comments
Closed

[Bug][Master] there exists some problems in checking task dependency #3324

legen618 opened this issue Jul 27, 2020 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@legen618
Copy link
Contributor

Describe the bug
There exists some problems in Master-Server executing logic. Some nodes could execute normally though their depenpency is not satisfied. Just like the screenshots below, if you get the same work flow, and you will find the result is wrong.

Screenshots
As you can see, task B shouldn't be executed which is the opposite of the result. When task X has condition-type node after, the tasks that depend on X will be probably executed.
微信图片_20200727231746

Which version of Dolphin Scheduler:
-[1.3.2-snapshot]

Probable reason

  • it's wrong because of the code below in the red rectangle.
    微信图片_20200727231733
@legen618 legen618 added the bug Something isn't working label Jul 27, 2020
@xingchun-chen
Copy link
Contributor

Whether the X task status of the custom parameter configuration in the condition node is successful or failed, can you take a screenshot of the configuration of the condition node

@legen618
Copy link
Contributor Author

Whether the X task status of the custom parameter configuration in the condition node is successful or failed, can you take a screenshot of the configuration of the condition node

Whether the X task status of the custom parameter configuration in the condition node is successful or failed, the result is the same.

@legen618
Copy link
Contributor Author

some similar problems are as follows:
bug
bug2

I'll fix it later this afternoon.

legen618 pushed a commit to legen618/incubator-dolphinscheduler that referenced this issue Jul 28, 2020
@lenboo lenboo added this to the 1.3.2-release milestone Jul 29, 2020
@petermenglei
Copy link

petermenglei commented Jul 31, 2020

I have the same issue here, after upgrade to version 1.3.0, all new created process have dependency issue (checked the configuration in table, No pretasks configured). anyone know to get around of this issue, even temporily?

@lenboo
Copy link
Contributor

lenboo commented Aug 3, 2020

I have the same issue here, after upgrade to version 1.3.0, all new created process have dependency issue (checked the configuration in table, No pretasks configured). anyone know to get around of this issue, even temporily?

you can submit another issue about 'no pretasks configured'.

legen618 pushed a commit to legen618/incubator-dolphinscheduler that referenced this issue Aug 4, 2020
@xingchun-chen
Copy link
Contributor

xingchun-chen commented Aug 14, 2020

  1. As shown in the figure below, node 5 should not be executed
    image
  2. As shown in the figure below, node 9 and node10 should not be executed
    image
    3.As shown in the figure below, "嵌套条件"node is not set to fail
    image

@lenboo lenboo removed this from the 1.3.2-release milestone Aug 17, 2020
@lenboo
Copy link
Contributor

lenboo commented Aug 17, 2020

i think we have some points about issue need to be discussed, so i will start a new discussion in mail list.

@xingchun-chen xingchun-chen added this to the 1.3.3-release milestone Sep 3, 2020
@lenboo lenboo modified the milestones: 1.3.3-release, 1.4.0 Sep 28, 2020
@lenboo lenboo removed this from the 1.4.0 milestone Nov 10, 2021
@apache apache locked and limited conversation to collaborators Nov 10, 2021
@lenboo lenboo closed this as completed Nov 10, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants