Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add api/controller unit test #1488

Merged
merged 3 commits into from
Dec 24, 2019
Merged

add api/controller unit test #1488

merged 3 commits into from
Dec 24, 2019

Conversation

xingchun-chen
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #1488 into dev will increase coverage by 4.05%.
The diff coverage is 21.11%.

Impacted file tree graph

@@           Coverage Diff            @@
##             dev   #1488      +/-   ##
========================================
+ Coverage   2.69%   6.75%   +4.05%     
========================================
  Files        271     272       +1     
  Lines      13593   13612      +19     
  Branches    2159    2165       +6     
========================================
+ Hits         367     920     +553     
+ Misses     13209   12628     -581     
- Partials      17      64      +47
Impacted Files Coverage Δ
.../org/apache/dolphinscheduler/common/Constants.java 0% <ø> (ø) ⬆️
.../server/worker/task/processdure/ProcedureTask.java 0% <0%> (ø) ⬆️
...server/master/runner/MasterBaseTaskExecThread.java 0% <0%> (ø) ⬆️
...ler/server/master/runner/MasterTaskExecThread.java 0% <0%> (ø) ⬆️
...cheduler/api/service/ProcessDefinitionService.java 0% <0%> (ø) ⬆️
...nscheduler/server/worker/task/spark/SparkTask.java 0% <0%> (ø) ⬆️
...nscheduler/server/worker/task/shell/ShellTask.java 0% <0%> (ø) ⬆️
...scheduler/server/worker/task/AbstractYarnTask.java 0% <0%> (ø) ⬆️
...er/server/worker/task/dependent/DependentTask.java 0% <0%> (ø) ⬆️
...lphinscheduler/server/worker/task/sql/SqlTask.java 0% <0%> (ø) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf9fbc...5a96b43. Read the comment docs.

Copy link
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 10c39db into apache:dev Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants