fix MasterBaseTaskExecThread submit method bug #1532
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1532 +/- ##
========================================
+ Coverage 7.4% 7.78% +0.38%
========================================
Files 272 272
Lines 13643 13646 +3
Branches 2170 2168 -2
========================================
+ Hits 1010 1063 +53
+ Misses 12566 12511 -55
- Partials 67 72 +5
Continue to review full report at Codecov.
|
...src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterBaseTaskExecThread.java
Outdated
Show resolved
Hide resolved
| @@ -74,6 +74,9 @@ public TaskInstance getTaskInstance(){ | |||
| public Boolean submitWaitComplete() { | |||
| Boolean result = false; | |||
| this.taskInstance = submit(); | |||
| if(this.taskInstance == null){ | |||
| return result; | |||
There was a problem hiding this comment.
should this return be checked whether the process instance is can be continue normally?
i am not sure about this.
There was a problem hiding this comment.
@qiaozhanwei how about your idea
There was a problem hiding this comment.
Should we send alert here if submit failed?
There was a problem hiding this comment.
1，Uncertain return, it is recommended to debug
2，submit failed should be logs and mail
There was a problem hiding this comment.
yes, I debug for submit fail test, process will end and be a failure state.
it is satisfied the result.
| @@ -74,6 +74,9 @@ public TaskInstance getTaskInstance(){ | |||
| public Boolean submitWaitComplete() { | |||
| Boolean result = false; | |||
| this.taskInstance = submit(); | |||
| if(this.taskInstance == null){ | |||
| return result; | |||
There was a problem hiding this comment.
1，Uncertain return, it is recommended to debug
2，submit failed should be logs and mail
No description provided.