-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor zk client and zk config module #1537
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1537 +/- ##
========================================
- Coverage 7.42% 7.27% -0.16%
========================================
Files 272 278 +6
Lines 13634 13738 +104
Branches 2169 2196 +27
========================================
- Hits 1012 999 -13
- Misses 12555 12674 +119
+ Partials 67 65 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TaskQueueZkImpl is not nice.
Should not have initZkClient to init zk.
System should use the same client in ZookeeperOperator
yeah~, I have find a better way to handle this, I will implement it later |
* @param cachePath zk path | ||
* @param listener operator | ||
*/ | ||
public void registerListener(final String cachePath, final TreeCacheListener listener) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a good way here
listen a base path is why AbstractListener borns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I get it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
What is the purpose of the pull request
the main purpose of this pr is to refactor the dependency on zk, including zk config dependency & zk client dependency.
Brief change log
In the process of refactoring, I have tried to be compatible with the previous code as much as possible, but still involves more file changes, so here are some important points that need to be explained for the convenience of code review
Verify this pull request
This pull request is code refactor and whether the refactoring solution is feasible still needs everyone to point out, If the final plan is passed, I will continue to add all the UT involved in this pr