-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor login verification process #1543
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1543 +/- ##
========================================
+ Coverage 7.76% 8.49% +0.72%
========================================
Files 272 275 +3
Lines 13641 13684 +43
Branches 2166 2171 +5
========================================
+ Hits 1059 1162 +103
+ Misses 12511 12446 -65
- Partials 71 76 +5
Continue to review full report at Codecov.
|
d079c50
to
04823c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a very nice pr for authenticating extension. Users can implement some more authentication based on encryption.
We just need more tests !
@qiaozhanwei
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
application-combined.properties doesn't needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
What is the purpose of the pull request
Refactor login authentication process, use interface
Brief change log
Verify this pull request
This change added tests and can be verified as follows: