Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor login verification process #1543

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

elonlo
Copy link
Contributor

@elonlo elonlo commented Dec 23, 2019

What is the purpose of the pull request

Refactor login authentication process, use interface

Brief change log

  • AuthenticationType file to dolphinscheduler-api module
  • Add AuthenticationType file to dolphinscheduler-api module
  • Add Authenticator file to dolphinscheduler-api module
  • Add SecurityConfig file to dolphinscheduler-api module
  • Add PasswordAuthenticator file to dolphinscheduler-api module
  • Add LoginHandlerInterceptorTest file to dolphinscheduler-api module
  • Add SecurityConfigTest file to dolphinscheduler-api module
  • Add PasswordAuthenticatorTest file to dolphinscheduler-api module
  • Modify LoginHandlerInterceptor file
  • Modify LoginController file
  • Modify TenantService file
  • Modify UsersService file

Verify this pull request

This change added tests and can be verified as follows:

  • Added PasswordAuthenticatorTest to verify password authenticator.
  • Added LoginHandlerInterceptorTest to verify interceptor.
  • Add SecurityConfigTest to verify authenticator is available.
  • Manually verified the change by testing locally.

@codecov-io
Copy link

codecov-io commented Dec 23, 2019

Codecov Report

Merging #1543 into dev will increase coverage by 0.72%.
The diff coverage is 33.82%.

Impacted file tree graph

@@           Coverage Diff            @@
##             dev   #1543      +/-   ##
========================================
+ Coverage   7.76%   8.49%   +0.72%     
========================================
  Files        272     275       +3     
  Lines      13641   13684      +43     
  Branches    2166    2171       +5     
========================================
+ Hits        1059    1162     +103     
+ Misses     12511   12446      -65     
- Partials      71      76       +5
Impacted Files Coverage Δ
...he/dolphinscheduler/api/service/TenantService.java 0.87% <0%> (+0.87%) ⬆️
...che/dolphinscheduler/api/service/UsersService.java 0.36% <0%> (+0.36%) ⬆️
...lphinscheduler/api/controller/LoginController.java 3.33% <0%> (+3.33%) ⬆️
...duler/api/interceptor/LoginHandlerInterceptor.java 66.66% <100%> (+66.66%) ⬆️
...phinscheduler/api/security/AuthenticationType.java 100% <100%> (ø)
...nscheduler/api/security/PasswordAuthenticator.java 50% <50%> (ø)
.../dolphinscheduler/api/security/SecurityConfig.java 64.28% <64.28%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d44d064...04823c2. Read the comment docs.

Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a very nice pr for authenticating extension. Users can implement some more authentication based on encryption.
We just need more tests !
@qiaozhanwei

Copy link
Contributor

@khadgarmage khadgarmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo requested a review from lenboo January 7, 2020 04:22
application-combined.properties doesn't needed
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 8ae401e into apache:dev Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants