New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-2815][server] One worker can belong to different workergroups #2934
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2934 +/- ##
============================================
- Coverage 33.52% 33.38% -0.14%
+ Complexity 2393 2389 -4
============================================
Files 442 443 +1
Lines 20596 20648 +52
Branches 2522 2526 +4
============================================
- Hits 6905 6894 -11
- Misses 13029 13094 +65
+ Partials 662 660 -2
Continue to review full report at Codecov.
|
6ad6b5f
to
476f787
Compare
sorry for not review in time, please solve conflicting files first |
476f787
to
425fc00
Compare
Thx a lot for your review @dailidong , I've rebased the branch and resolved the conflicts. |
01c3958
to
c8e3891
Compare
...-server/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistry.java
Show resolved
Hide resolved
7c9acd0
to
f53450b
Compare
ddfea80
to
40f9f25
Compare
655570e
to
8cf4cb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 please resove conflicting , Thx
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Hi, |
What is the purpose of the pull request
Implement one worker can belong to different workergroups(#2591 ) (#2815 )
Brief change log
worker.group
conf toworker.groups
server/worker/config/WorkerConfig#workerGroup
toserver/worker/config/WorkerConfig#workerGroups
Verify this pull request
This change added tests and can be verified as follows: