-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace CollectionUtils deprecated method #3027
Conversation
BeanUtils Check dependency license fail,so,I copied it to my project |
@CalvinKirs SonarCloud Code Analysis test failed |
commons-bean Check dependency license fail ,so,I copied bean-map to my project,I don’t know if it’s acceptable or not, I hope to get some suggestions from you |
@CalvinKirs If the beanMap class deprecated, so there is an alternative ? Only copying it might not be a good solution |
Thank you very much for your suggestion. You are right. In fact, I also feel that it is rude to directly copy this method, I think I can achieve the same function in other ways. I will finish it later it. |
I have completed the change, I’m sorry to trouble you to have time to review @gabrywu |
Hi,you should describe detail as following when update the pom dependency. |
Thank you very much for your review. I didn’t remove the jar. I changed it to beanMap because the original method was deprecated. I added common-beanutils, which was originally in the parent pom, but no license was added, I fixed it It, its address is https://github.com/apache/commons-beanutils |
Codecov Report
@@ Coverage Diff @@
## dev #3027 +/- ##
============================================
- Coverage 33.39% 33.38% -0.02%
+ Complexity 2373 2371 -2
============================================
Files 441 441
Lines 20518 20518
Branches 2505 2505
============================================
- Hits 6853 6850 -3
- Misses 13018 13020 +2
- Partials 647 648 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
please resolve conflicting files . Thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
good job
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thanks for your review, I have completed the changes, please check again, Thx |
Tips
What is the purpose of the pull request
replace CollectionUtils deprecated method
Verify this pull request
(Please pick either of the following options)
This pull request is already covered by existing tests, such as (please describe tests).