[Feature-docker][all-service] refactor the Dockerfile for smaller size #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor the Dockerfile and build script * ignore some files and directory
khadgarmage
requested changes
Jul 23, 2020
docker/build/Dockerfile
Outdated
| @@ -1,82 +1,49 @@ | |||
| # | |||
There was a problem hiding this comment.
why delete the license header?
| # docker build | ||
| echo -e "docker build --build-arg VERSION=${VERSION} -t $DOCKER_REPO:${VERSION} $(pwd)/docker/build/\n" | ||
| sudo docker build --build-arg VERSION=${VERSION} -t $DOCKER_REPO:${VERSION} $(pwd)/docker/build/ | ||
| echo -e "docker build -f docker/build/Dockerfile -t $DOCKER_REPO:${VERSION} $(pwd)\n" |
There was a problem hiding this comment.
Because of at the builder phase, copy src should from root path.
|
Hi, please resolve the conflict.. If there is no update after 7 days, the PR will be closed, and you can reopen it when your problem is resolved. |
davidzollo
pushed a commit
that referenced
this pull request
Jan 29, 2021
… nginx and improve log out (#4529) * [Improvement][Docker] Reduce docker image size * [Improvement][Docker] Improve log out * [Improvement][Docker] Chmod +x to script files * [Improvement][Docker] Remove frontend and fix docker statck deploy * [Fix][Docker] Fix e2e test * [Improvement][Docker] Revert log appender * [Improvement][Docker] Remove stdout log appender
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
Brief change log
Verify this pull request
(Please pick either of the following options)
This pull request is code cleanup without any test coverage.