Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] isssue #3299 #3300

Closed
wants to merge 25 commits into from
Closed

[BugFix] isssue #3299 #3300

wants to merge 25 commits into from

Conversation

JinyLeeChina
Copy link
Contributor

Fixed alert cannot be notified,when master or worker shutdown。
I think the reason for this is that Jackson can't parse JSON fields with single quotes.

@JinyLeeChina
Copy link
Contributor Author

Fixed alert cannot be notified,when master or worker shutdown。
I think the reason for this is that Jackson can't parse JSON fields with single quotes.

Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei
Copy link
Contributor

why all red compile not pass

@EricJoy2048 EricJoy2048 self-requested a review July 24, 2020 07:16
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some test is failed

@yangyichao-mango
Copy link
Contributor

yangyichao-mango commented Jul 24, 2020

Hi,
The type of {'a': "b"} and {'a': 'b'} is not a standard json string, but if we add the ALLOW_SINGLE_QUOTES, it will be formatted correctly by JSONUtils. If we just add ALLOW_SINGLE_QUOTES for JSONUtils, perhaps it will cause some unforeseen bugs.
I think a better way to fix this bug is format the original json not to change the JSONUtils.
image

@JinyLeeChina
Copy link
Contributor Author

I think we should be compatible with JSON with single quotation marks

@JinyLeeChina
Copy link
Contributor Author

Update actions.js fixed #3351

@lenboo
Copy link
Contributor

lenboo commented Aug 4, 2020

Hi,

Please change the title to [Fix-3299][ui] process_definition_json contains definitionList,but this definitionList is not use . Thx

@break60
Copy link
Contributor

break60 commented Aug 4, 2020

+1

@lenboo
Copy link
Contributor

lenboo commented Aug 5, 2020

there is another pr refer to the issue, so i will close this.

@lenboo lenboo closed this Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants