Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]add presto datasource support #3308

Merged
merged 5 commits into from Aug 14, 2020
Merged

Conversation

rockxsj
Copy link
Contributor

@rockxsj rockxsj commented Jul 25, 2020

Tips

What is the purpose of the pull request

update .gitigonre to igonre some files
add presto datasource support

Brief change log

        new file:   dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/PrestoDataSource.java
        modified:   .gitignore
        modified:   dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
        modified:   dolphinscheduler-common/pom.xml
        modified:   dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
        modified:   dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/DbType.java
        modified:   dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/BaseDataSource.java
        modified:   dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/DataSourceFactory.java
        modified:   dolphinscheduler-ui/src/js/conf/home/pages/datasource/pages/list/_source/createDataSource.vue
        modified:   dolphinscheduler-ui/src/js/conf/home/store/dag/state.js
        modified:   dolphinscheduler-ui/src/js/conf/home/store/datasource/actions.js
        modified:   pom.xml

Verify this pull request

This pull request is already covered by existing tests.

rockxsj added 2 commits July 25, 2020 17:30
update .gitigonre to igonre some files
@CalvinKirs
Copy link
Member

Good job, adding a new jar requires sending an email to dev and getting approval from PPMC. At the same time, you can refer to the following article to check by yourself first.
https://github.com/apache/incubator-dolphinscheduler-website/blob/master/docs/zh-cn/development/DS-License.md

@rockxsj
Copy link
Contributor Author

rockxsj commented Jul 27, 2020

Good job, adding a new jar requires sending an email to dev and getting approval from PPMC. At the same time, you can refer to the following article to check by yourself first.
https://github.com/apache/incubator-dolphinscheduler-website/blob/master/docs/zh-cn/development/DS-License.md

done

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yangyichao-mango
Copy link
Contributor

Good job,
Please add test case to resolve the sonar 0.0% coverage.

@dengc367
Copy link
Contributor

dengc367 commented Aug 9, 2020

you need change the presto driver name com.facebook.presto.jdbc.PrestoDriver in presto driver configuration, not io.prestosql.jdbc.PrestoDriver when you use the facebook presto-jdbc jar , @rockxsj

@dengc367
Copy link
Contributor

I have modify some code from this presto feature and submit another pull request [Feature]modify some cases from rockxsj:Feature-presto to add presto datasource support
thanks @rockxsj for the codes.

@davidzollo davidzollo added this to the 1.4.0 milestone Aug 14, 2020
@davidzollo davidzollo added this to Requirement(需求) in DolphinScheduler Work Plan via automation Aug 14, 2020
@davidzollo davidzollo moved this from Requirement(需求) to Done(当前完成的任务) in DolphinScheduler Work Plan Aug 14, 2020
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job
I noticed that PR #3468 solved two bugs base on this PR,I will let him handle the potential conflict files and fix the bugs

DolphinScheduler Work Plan automation moved this from Done(当前完成的任务) to Doing(正在开发中) Aug 14, 2020
@davidzollo davidzollo merged commit 2b46db0 into apache:dev Aug 14, 2020
DolphinScheduler Work Plan automation moved this from Doing(正在开发中) to Done(当前完成的任务) Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants