Fixed bug which palo can't compiled by JDK 10, added the compile parameter CPPFLAGS of ncurses-6.0, prevent compilation error #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter CPPFLAGS of ncurses-6.0, prevent compilation error
|
Doris team here is an open Pull Request |
|
Yes, we already accepted this pull request on our private code repo. We are currently trying to find a better way to merge our private code to the apache repo, to avoid chaos on merging code. it may take a while. |
|
Please discuss this process and structure on the dev list. I'd like to understand what the challenges are so that the solution worked out is the best. Keep in mind that the Baidu/palo repository was what was granted to the Apache Software Foundation and one task will be to make sure that all source files have all the proper headers, etc. |
lide-reed
approved these changes
Sep 20, 2018
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
Jul 26, 2023
yiguolei
pushed a commit
that referenced
this pull request
Sep 28, 2023
Current multi-window plan generation has problem on the project sequence, for example: +--LogicalWindow ( windowExpressions=[avg(sum_sales#115) WindowSpec(...) AS `avg_monthly_sales`#116, rank() WindowSpec(...) AS `rn`#117], ...) and correspond physical plan is: +--PhysicalWindow[6572]@16 ( windowFrameGroup=(Funcs=[avg(sum_sales#115) WindowSpec(...) AS `avg_monthly_sales`#116], ... ) +--PhysicalWindow[6568]@29 ( windowFrameGroup=(Funcs=[rank() WindowSpec(...) AS `rn`#117], ...] ) If the final plan is generated as following: MultiCastDataSinks STREAM DATA SINK EXCHANGE ID: 20 HASH_PARTITIONED: rn[#208], i_brand[#202], cc_name[#203], i_category[#201] Before we eventually resolve the multi-window issue, we add a projection as following and force a mapping but this will not cover all potential problems. MultiCastDataSinks STREAM DATA SINK EXCHANGE ID: 20 HASH_PARTITIONED: rn[#219], i_brand[#213], cc_name[#214], i_category[#212] PROJECTIONS: i_category[#184], i_brand[#185], cc_name[#186], d_year[#187], d_moy[#188], sum_sales[#189], avg_monthly_sales[#191], rn[#190] PROJECTION TUPLE: 20
vinlee19
pushed a commit
to vinlee19/doris
that referenced
this pull request
Oct 7, 2023
…24912) Current multi-window plan generation has problem on the project sequence, for example: +--LogicalWindow ( windowExpressions=[avg(sum_sales#115) WindowSpec(...) AS `avg_monthly_sales`apache#116, rank() WindowSpec(...) AS `rn`apache#117], ...) and correspond physical plan is: +--PhysicalWindow[6572]@16 ( windowFrameGroup=(Funcs=[avg(sum_sales#115) WindowSpec(...) AS `avg_monthly_sales`apache#116], ... ) +--PhysicalWindow[6568]@29 ( windowFrameGroup=(Funcs=[rank() WindowSpec(...) AS `rn`apache#117], ...] ) If the final plan is generated as following: MultiCastDataSinks STREAM DATA SINK EXCHANGE ID: 20 HASH_PARTITIONED: rn[apache#208], i_brand[apache#202], cc_name[apache#203], i_category[apache#201] Before we eventually resolve the multi-window issue, we add a projection as following and force a mapping but this will not cover all potential problems. MultiCastDataSinks STREAM DATA SINK EXCHANGE ID: 20 HASH_PARTITIONED: rn[apache#219], i_brand[apache#213], cc_name[apache#214], i_category[apache#212] PROJECTIONS: i_category[apache#184], i_brand[apache#185], cc_name[apache#186], d_year[apache#187], d_moy[apache#188], sum_sales[apache#189], avg_monthly_sales[apache#191], rn[apache#190] PROJECTION TUPLE: 20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.