Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DB meta lost bug 2 #2174

Merged
merged 1 commit into from Nov 12, 2019
Merged

Fix DB meta lost bug 2 #2174

merged 1 commit into from Nov 12, 2019

Conversation

kangkaisen
Copy link
Contributor

For #2167

I didn't notice CHECKPOINT catalog will destroy after every saveImage.

finally {
            // destroy checkpoint catalog, reclaim memory
            catalog = null;
            Catalog.destroyCheckpoint(); 
        }

So the following check is meaningless, fullNameToDb always don't contain InfoSchemaDb name.

if (!fullNameToDb.containsKey(dbName)) {

So I use real Catalog instance fullNameToDb to do this check.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay closed this Nov 11, 2019
@imay imay reopened this Nov 11, 2019
@morningman morningman merged commit b4d6301 into apache:master Nov 12, 2019
morningman pushed a commit to morningman/doris that referenced this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants