[Insert] Return more info of insert operation #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardize the return results of INSERT operations, which is convenient for users to use and locate problems. More details can be found in insert-into-manual.md
EmmyMiao87
reviewed
Jan 14, 2020
| analyzeSubPredicate(whereClause); | ||
| } | ||
|
|
||
| private void analyzeSubPredicate(Expr subExpr) throws AnalysisException { |
|
|
||
| boolean valid = true; | ||
| CHECK: { | ||
| if (subExpr instanceof BinaryPredicate) { |
There was a problem hiding this comment.
if the stmt is where 1=id?
|
|
||
| // {'label':'my_label1', 'status':'visible', 'txnId':'123'} | ||
| // {'label':'my_label1', 'status':'visible', 'txnId':'123' 'err':'error messages'} | ||
| String info = "{'label':'" + label + "', 'status':'" + txnStatus.name() + "', 'txnId':'" |
| throw new AnalysisException("transaction with id " + txnId + " does not exist"); | ||
| } | ||
|
|
||
| if (ConnectContext.get() != null) { |
There was a problem hiding this comment.
This method may be called internal, not in user connection thread. So I just add a judgement here.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jan 15, 2020
Standardize the return results of INSERT operations, which is convenient for users to use and locate problems. More details can be found in insert-into-manual.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize the return results of INSERT operations,
which is convenient for users to use and locate problems.
More details can be found in insert-into-manual.md
Also add a new stmt: SHOW TRANSACTION that user can see
the transaction status of the specified transaction id.
ISSUE: #2717