Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitamp_to_string function #2731

Merged
merged 3 commits into from Jan 13, 2020
Merged

Add bitamp_to_string function #2731

merged 3 commits into from Jan 13, 2020

Conversation

imay
Copy link
Contributor

@imay imay commented Jan 10, 2020

This CL changes:

  1. add function bitmap_to_string, which will convert a bitmap to string
    which contains all bit in bitmap
  2. add function murmur_hash3_32, which will compute murmur hash for
    input strings
  3. make the function cast float to string the same with user result
    logic

#2706

This CL changes:

1. add function bitmap_to_string, which will convert a bitmap to string
which contains all bit in bitmap
2. add function murmur_hash3_32, which will compute murmur hash for
input strings
3. make the function cast float to string the same with user result
logic
@imay imay added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 10, 2020
@imay imay self-assigned this Jan 10, 2020
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. LGTM

@imay imay merged commit a99a49a into apache:master Jan 13, 2020
@chaoyli chaoyli mentioned this pull request Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants