Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doris On ES][WIP] Support external ES table with SSL secured and configurable node sniffing #5325

Merged
merged 13 commits into from Apr 12, 2021
Merged

[Doris On ES][WIP] Support external ES table with SSL secured and configurable node sniffing #5325

merged 13 commits into from Apr 12, 2021

Conversation

stalary
Copy link
Contributor

@stalary stalary commented Jan 30, 2021 •
edited

Proposed changes

Support doris connect https es server and support config esNodesDiscovery

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Issue: #5324

wuyunfeng
wuyunfeng requested changes Feb 23, 2021
View reviewed changes
Copy link
Member

@wuyunfeng wuyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good job, I left some comment

be/src/exec/es/es_scan_reader.cpp Outdated Show resolved Hide resolved
be/src/exec/es/es_scan_reader.h Outdated Show resolved Hide resolved
fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsNodeInfo.java Outdated Show resolved Hide resolved
gensrc/thrift/Descriptors.thrift Outdated Show resolved Hide resolved
@wuyunfeng wuyunfeng changed the title WIP：Support doris connect https es server and support config esNodesDiscovery [Doris On ES][WIP]：Support ES with SSL secured and support disabling ES nodes detecting Feb 23, 2021
@wuyunfeng wuyunfeng self-assigned this Feb 23, 2021
@wuyunfeng wuyunfeng added the area/doris-on-es Issues or PRs related to Doris on ElasticSearch label Feb 23, 2021
@wuyunfeng wuyunfeng changed the title [Doris On ES][WIP]：Support ES with SSL secured and support disabling ES nodes detecting [Doris On ES][WIP]：Support ES with SSL secured and disabling ES nodes detecting Feb 23, 2021
@wuyunfeng wuyunfeng changed the title [Doris On ES][WIP]：Support ES with SSL secured and disabling ES nodes detecting [Doris On ES][WIP]：Support ES with SSL secured and configurable node sniffing Feb 23, 2021
@wuyunfeng wuyunfeng changed the title [Doris On ES][WIP]：Support ES with SSL secured and configurable node sniffing [Doris On ES][WIP] Support external ES table with SSL secured and configurable node sniffing Feb 23, 2021
@wuyunfeng wuyunfeng linked an issue Feb 23, 2021 that may be closed by this pull request
[Doris On ES][Feature] Does Doris support external ES table with SSL secured and configurable node sniffing? #5324
Closed
wuyunfeng
wuyunfeng requested changes Feb 24, 2021
View reviewed changes
be/src/exec/es/es_scan_reader.h Outdated Show resolved Hide resolved
be/src/http/http_client.h Outdated Show resolved Hide resolved
@apache apache deleted a comment from stalary Mar 4, 2021
wuyunfeng
wuyunfeng requested changes Apr 7, 2021
View reviewed changes
docs/en/extending-doris/doris-on-es.md Outdated Show resolved Hide resolved
docs/en/extending-doris/doris-on-es.md Outdated Show resolved Hide resolved
wuyunfeng
wuyunfeng previously approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@wuyunfeng wuyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuyunfeng wuyunfeng added the approved Indicates a PR has been approved by one committer. label Apr 9, 2021
wuyunfeng
wuyunfeng approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@wuyunfeng wuyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuyunfeng wuyunfeng merged commit 75db273 into apache:master Apr 12, 2021
@wuyunfeng wuyunfeng mentioned this pull request Apr 12, 2021
Open
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request May 14, 2021
@stalary @morningman-cmy
[Doris On ES][WIP] Support external ES table with SSL secured and c…
8b91d67 
…onfigurable node sniffing (apache#5325)

Support external ES  table with `SSL` secured and configurable node sniffing
@morningman morningman mentioned this pull request Oct 10, 2021
Closed
@stalary stalary deleted the es_ssl branch May 8, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuyunfeng wuyunfeng wuyunfeng approved these changes

Assignees

@wuyunfeng wuyunfeng

Labels
approved Indicates a PR has been approved by one committer. area/doris-on-es Issues or PRs related to Doris on ElasticSearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doris On ES][Feature] Does Doris support external ES table with SSL secured and configurable node sniffing?
2 participants
@stalary @wuyunfeng