* Use @SuppressWarnings("GuardedBy") instead of `noinspection Field…

…AccessNotGuarded` comment (#6903) * Remove `@GuardedBy("connectionLock")` from `connectionLock` itself * Add FieldAccessNotGuarded into inspection profile and set the level to ERROR
apache · Jan 27, 2019 · 2b73644 · 2b73644
1 parent ae4dba7
commit 2b73644
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.idea/inspectionProfiles/Druid.xml b/.idea/inspectionProfiles/Druid.xml
diff --git a/sql/src/main/java/org/apache/druid/sql/avatica/DruidConnection.java b/sql/src/main/java/org/apache/druid/sql/avatica/DruidConnection.java
@@ -56,9 +56,8 @@ public class DruidConnection
 
   // Typically synchronized by connectionLock, except in one case: the onClose function passed
   // into DruidStatements contained by the map.
-  private final ConcurrentMap<Integer, DruidStatement> statements;
-
   @GuardedBy("connectionLock")
+  private final ConcurrentMap<Integer, DruidStatement> statements;
   private final Object connectionLock = new Object();
 
   @GuardedBy("connectionLock")
@@ -94,6 +93,7 @@ public DruidStatement createStatement(SqlLifecycleFactory sqlLifecycleFactory)
           e -> !SENSITIVE_CONTEXT_FIELDS.contains(e.getKey())
       );
 
+      @SuppressWarnings("GuardedBy")
       final DruidStatement statement = new DruidStatement(
           connectionId,
           statementId,