Fix the broken Appenderator contract in KafkaIndexTask #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The threading changes look OK to me, can you describe more in the PR why the things removed from the pause/resume handling were unnecessary? I don't think I understood that part |
|
@jon-wei thank you for the review. I've updated the PR description. |
jon-wei
approved these changes
Jul 3, 2018
jihoonson
added a commit
to implydata/druid-public
that referenced
this pull request
Jul 3, 2018
* Fix broken Appenderator contract in KafkaIndexTask * fix build * add publishFuture * reuse sequenceToUse if possible
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 5, 2018
* Fix broken Appenderator contract in KafkaIndexTask * fix build * add publishFuture * reuse sequenceToUse if possible
jihoonson
added a commit
to jihoonson/druid
that referenced
this pull request
Jul 9, 2018
* Fix broken Appenderator contract in KafkaIndexTask * fix build * add publishFuture * reuse sequenceToUse if possible
jihoonson
added a commit
that referenced
this pull request
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5729.
Mainly, I removed
publishQueueandpublishExecServicefromIncrementalIndexingKafkaTaskRunnerwhich caused #5729. Instead,AppenderatorDriver(and thusAppenderatorAPIs are called by the same thread. SeepublishAndRegisterHandoff().I additionally removed some unnecessary or unused variables.
pauseAfterReadfromKafkaIOConfigbecause it was alwaysfalse.pauseMillisfromIncrementalIndexingKafkaTaskRunnerandtimeoutparameter from thepause()api. Those two variables are designed only forpauseAfterRead. Since that parameter is not used,pauseMilliswas alwaysPAUSE_FOREVERandtimeoutwas always 0.resumeparameter fromsetEndoffsets()api. This parameter was also used only forpauseAfterReadand alwaystrue.Also,
setOffsets()API now returnsINTERNAL_SERVER_ERRORon failure.This change is