Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies

[samarthjain]

As an example, if composite request logger uses FileRequestLogger as one of the loggers to use, then we need to make sure that the FileRequestLogger is properly initialized by invoking a method annotated as @LifeCycleStart.

`
@LifecycleStart
public void start()
{
...

  baseDir.mkdirs();
  MutableDateTime mutableDateTime = DateTimes.nowUtc().toMutableDateTime(ISOChronology.getInstanceUTC());
  mutableDateTime.setMillisOfDay(0);
  synchronized (lock) {
    currentDay = mutableDateTime.toDateTime(ISOChronology.getInstanceUTC());

    fileWriter = getFileWriter();
  }

`

It seems like just annotating methods with LifeCycleStart/stop isn't enough. I am not too sure why but it looks like because I have configured composite request logging.
druid.request.logging.type=composing druid.request.logging.loggerProviders=[{"type":"file", "dir":"/logs/druid"}, {"type":"emit"}]
Without the change that this PR is proposing, logging using the FileRequestLogger fails with an NPE because fileWriter isn't initialized. Simply annotating a method in CompositeRequestLogger as @LifeCycleStart isn't enough either since it won't invoke the corresponding @LifeCycleStart method on the FileRequestLogger unless I call it explicitly.

[jihoonson]

Hi @samarthjain, thank you for the PR. Would you add some more details about this change to the PR description? It's not intuitive to me because it looks that any class annotated with LifecycleStart and LifecycleStop should be started/stopped automatically without this change if they are properly added to the Lifecycle.

[samarthjain]

Thanks for taking a look, @jihoonson. I have updated the PR description.

[jihoonson]

Thanks @samarthjain! This PR looks good to me.

[gianm]

This seems a little ugly. How about adding start and stop methods to the RequestLogger interface instead? It can be backwards compatible through default methods.

[jihoonson]

@gianm sounds good to me.

[samarthjain]

Thanks for the reviews. I have updated the PR.

[jihoonson]

The latest change looks good to me. @gianm do you have more comments?

[gianm]

Thanks, this looks good.