trigger clean dir when unzip fails with IOException #6178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SegmentManager, SegmentLoaderLocalCacheManager, and many pullers catch IOException and wrap IOException as SegmentLoadingException, and only clean dir when SegmentLoadingException happens.
But the
unzip
method will wrap all exceptions to RuntimeException, then the clean logic is not going to be triggered.unzip
should try best to throw IOException instead of RuntimeException